privacy-scaling-explorations / sonobe

Experimental folding schemes library
https://privacy-scaling-explorations.github.io/sonobe-docs/
MIT License
208 stars 55 forks source link

Update NonNativeAffineVar approach #65

Closed arnaucube closed 2 months ago

arnaucube commented 9 months ago

NonNativeAffineVar was a way to represent curve points non-natively, but the current implementation misses checking that the coordinates are of a valid point, thus invalid points could be witnessed. Need to either update NonNativeAffineVar or analyze other possible approaches for working with these points (eg. arkworks CurveVar but over NonNativeFieldVar), or analyzing the security of checking the points in the circuit over the other curve natively.

arnaucube commented 2 months ago

Closing as this is not needed: on the main circuit the points are not checked and are represented as non-native, but in the CycleFold the same points are witnessed with the Arkworks's default native curve points structs. And typical folding checks are in place to ensure that the points in the main circuit are the same as in the CycleFold circuit.