search

privacy-scaling-explorations / zk-kit.circom

A monorepo of reusable Circom circuits.
MIT License
14 stars 2 forks source link

Add Circomspect to circom circuits #4

Closed vplasencia closed 2 months ago

vplasencia commented 5 months ago

Description

Circomspect is a static analyzer and linter for the Circom zero-knowledge DSL: https://github.com/trailofbits/circomspect. It helps identify potential issues on ZK-Kit circuits.

Resources: https://blog.trailofbits.com/2022/09/15/it-pays-to-be-circomspect/

sripwoud commented 5 months ago

Nice, I discovered it last week too. Can I implement this? Do you want to have this run only in the ci? Or do you want also to add local scripts?

This may be not so easy, because all the circom circuits imports are handled with circomkit. Not sure how this will play with circomspect

sripwoud commented 5 months ago

Made me think about checks we can also do with nargo privacy-scaling-explorations/zk-kit.noir#2

cedoor commented 5 months ago

@sripwoud

Can I implement this?

Of course!

Do you want to have this run only in the ci? Or do you want also to add local scripts?

Both of them would be nice. It could be optional locally though.