Use `if` instead of `while` to increment depth in the `LeanIMT.insert` function - Githubissues

privacy-scaling-explorations / zk-kit

A monorepo of reusable libraries for zero-knowledge technologies.

https://zkkit.pse.dev

MIT License

295 stars 80 forks source link

Use `if` instead of `while` to increment depth in the `LeanIMT.insert` function #219

Closed cedoor closed 8 months ago

cedoor commented 8 months ago

Description

A new insertion can increase a tree's depth by at most 1. We can be sure that the while loop isn't executed twice.

Related Issue(s)

Closes #213

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have run yarn prettier and yarn lint without getting any errors
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules