privacy-scaling-explorations / zk-kit

A monorepo of reusable libraries for zero-knowledge technologies.
https://zkkit.pse.dev
MIT License
295 stars 80 forks source link

Update removed nodes #229

Closed vplasencia closed 8 months ago

vplasencia commented 8 months ago

Description

This PR:

Related Issue(s)

Closes #228

Checklist

0xbok commented 8 months ago

looks good. i'd also update/add a test where after deleting a leaf, self._has(0) is asserted to be false.

vplasencia commented 8 months ago

Hey @0xbok! I think that's covered in the test Should not update a leaf that was removed, but it makes sense to add one just for it in the has section. Thanks.

vplasencia commented 8 months ago

@0xbok done ✅