privacy-scaling-explorations / zk-kit

A monorepo of reusable libraries for zero-knowledge technologies.
https://zkkit.pse.dev
MIT License
291 stars 79 forks source link

More comments for explicit mod reduction on inputs #248

Closed cedoor closed 7 months ago

cedoor commented 7 months ago

Description

This PR doesn't fix #241. In order to keep the F1Field functions light and more efficient devs should check themselves if the input values are within the field. A comment has been added to the module to be more explicit.

This PR also updates tests by removing unnecessary BigInt conversions.

Related Issue(s)

Closes #241

Checklist