Closed 0xbok closed 7 months ago
@cedoor unrelated tests are failing due to some noir issues, so this shouldn't block this pr from merging?
@cedoor unrelated tests are failing due to some noir issues, so this shouldn't block this pr from merging?
No, that's not related to this PR.
Description
f1-field test is using composite order for which inverse of some of the non-zero elements doesn't exist. The invinv fn produces garbage for these values and inv test uses those values for assertion. This commit changes the order to prime number.
I've also tried to improve the tests as some functions were tested on trivial values.
Related Issue(s)
Closes #251
Checklist
yarn style
without getting any errors