ci: optimize CI behavior

privacy-scaling-explorations / zk-kit

A monorepo of reusable libraries for zero-knowledge technologies.

https://zkkit.pse.dev

MIT License

290 stars 76 forks source link

ci: optimize CI behavior #268

Closed baumstern closed 7 months ago

baumstern commented 7 months ago

This PR introduces several optimizations to our CI pipeline.

Key Changes

remove redundant dependencies
skip unnecessary dependency installations
disable fail-fast to continue tests after a failure; even if one fails, ensuring comprehensive test results
cancel obsolete CI runs when a new commit is pushed to a PR

Closes #266

baumstern commented 7 months ago

The test is failing with following error 🤔


  115 passing (10m)
  1 failing

  1) QuinaryIMT
       # update
         Should not update a leaf that hasn't been inserted yet:
     AssertionError: Expected transaction to be reverted with custom error 'LeafIndexOutOfRange', but it reverted with custom error 'LeafDoesNotExist'
      at async Context.<anonymous> (test/QuinaryIMT.ts:192:13)

cedoor commented 7 months ago

@baumstern I think this has something to do with parallel tests and Turbo.

@sripwoud Could that be the problem here? It looks like it fails sometimes, but not always.

baumstern commented 7 months ago

quick heads-up:

I've added commit 3b2df4f to ensure the website build isn't broken when a PR is opened. Currently, docs.yml workflows are triggered only when code is pushed to the main branch