privacy-scaling-explorations / zk-kit

A monorepo of reusable libraries for zero-knowledge technologies.
https://zkkit.pse.dev
MIT License
291 stars 79 forks source link

chore: remove solidity packages and conf #286

Closed cedoor closed 6 months ago

cedoor commented 6 months ago

Description

This PR removes all code related to Solidity as it has been moved to another ZK-Kit repository: https://github.com/privacy-scaling-explorations/zk-kit.solidity.

It also optimizes the Github workflows and removes legacy JS packages (groth16 and rollup-plugin-rust).

Related Issue(s)

Closes #282

Checklist

cedoor commented 6 months ago

@sripwoud @baumstern It would be nice to have your feedback for files related to turbo and workflows.

sripwoud commented 6 months ago

Not related to this PR, but to the new zk-kit.{circom,solidity,noir}: Do we want to keep using turbo there? Not saying we should...I just don't see it used anymore. I didn't test the scripts in these new repos to have a feeling for their speed and assess whether turbo would be beneficial or overkill. I guess it is very likely overkill for the noir repo. But maybe useful for circom that contains lot of subpackages already ... and solidity?

cedoor commented 6 months ago

I guess it is very likely overkill for the noir repo. But maybe useful for circom that contains lot of subpackages already ... and solidity?

I've not added it because I've not studied it yet. But if you think they could benefit from it please test them!