search

privacy-scaling-explorations / zkevm-circuits

https://privacy-scaling-explorations.github.io/zkevm-circuits/
Other
819 stars 857 forks source link

Unify tables.rs table methods into `LookupTable` trait fns. #1141

Open CPerezz opened 1 year ago

CPerezz commented 1 year ago

Almost all of the lookup tables defined in tables.rs actually have the methods construct, assignments, load...

I think we could integrate all these inside of the LookupTable trait. Specially after the first refactor of this trait. Which was done in #1137

ed255 commented 1 year ago

The word lo/hi refactor touches most of the Tables tables.rs. I suggest we block this issue until https://github.com/privacy-scaling-explorations/zkevm-circuits/issues/1221 is completed.