privacy-scaling-explorations / zkevm-circuits

https://privacy-scaling-explorations.github.io/zkevm-circuits/
Other
818 stars 854 forks source link

chore: set resolver v2 at the workspace level #1731

Closed bishopcheckmate closed 8 months ago

bishopcheckmate commented 8 months ago

Description

Cargo defaults to resolver = "2" in edition 2021 only for singular crates. Workspace tho defaults to the old resolver = "1" and will override this setting for all crates in the workspace. The guideline is to manually set the resolver = "2" on workspace level. This was documented recently and since a few releases produces a warning on building. You don't see it due to the rust-toolchain setting.

Type of change

Contents

This also fixes this warning:

warning: resolver for the non root package will be ignored, specify resolver at the workspace root:
package:   /data/bishop/zkevm-circuits/light-client-poc/Cargo.toml
workspace: /data/bishop/zkevm-circuits/Cargo.toml
bishopcheckmate commented 8 months ago

I pushed the commit which should fix the builds. With resolver = 2, selected features are not propagated through different dependency types and targets so ethers-solc had to be explicitly enabled in build deps