Refactor: use StepRws in evm circuits to replace rw indices - Githubissues

privacy-scaling-explorations / zkevm-circuits

https://privacy-scaling-explorations.github.io/zkevm-circuits/

Other

821 stars 841 forks source link

Refactor: use StepRws in evm circuits to replace rw indices #1786

Closed maschad closed 3 months ago

maschad commented 4 months ago

Description

Continuing the work originally started in https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/1616 this PR seeks to introduce StepRws across the evm circuits to reduce the need for tracking rw indices through code.

Issue Link

Closes https://github.com/privacy-scaling-explorations/zkevm-circuits/issues/1586

Type of change

Refactor (no updates to logic)

Contents

The change has been made to the following files

error_oog_call.rs
error_oog_memory_copy.rs
error_oog_sload_sstore.rs
error_return_data_oo_bound.rs
error_write_protection.rs
extcodecopy.rs
extcodehash.rs
extcodesize.rs
logs.rs
return_revert.rs
returndatacopy.rs
sha3.rs
sload.rs
sstore.rs

maschad commented 4 months ago

@ChihChengLiang this should be ready for review now

maschad commented 4 months ago

Thanks for the review @miha-stopar ! I've made the changes.

maschad commented 3 months ago

Thanks for your review @ChihChengLiang I've made the requested adjustments.