State circuit spec sync - Githubissues

privacy-scaling-explorations / zkevm-circuits

https://privacy-scaling-explorations.github.io/zkevm-circuits/

Other

818 stars 854 forks source link

State circuit spec sync #1801

Open ChihChengLiang opened 6 months ago

ChihChengLiang commented 6 months ago

Describe the feature you would like

This issue collects the list of feedback to work on from https://github.com/privacy-scaling-explorations/zkevm-specs/pull/520

The file to modify is zkevm-circuits/src/circuit_tools/constraint_builder.rs

value_prev and value_prev_column are confusing names. @rrtoledo Suggest renaming them to:
- value_prev: WordLoHi<Expression>, // meta.query(value, Rotation::prev()) could be renamed value_rot_prev for instance
- pub value_prev_column: WordLoHi<Expression>, // meta.query(prev_value, Rotation::cur()) be renamed value_prev
https://github.com/privacy-scaling-explorations/zkevm-specs/pull/520#discussion_r1553259772

TBD

Additional context

No response