search

privacy-scaling-explorations / zkevm-circuits

https://privacy-scaling-explorations.github.io/zkevm-circuits/
Other
821 stars 841 forks source link

Testool fix from Scroll #1816

Open curryrasul opened 2 months ago

curryrasul commented 2 months ago

Description

This PR adds fixes from Scroll/testool - scroll-tech/zkevm-circuits#1235.

Initially I wanted to do that by cherry-pick, but it added much more here - so I did it manually.

curryrasul commented 2 months ago

Another question - do we need to do changes in codehash.txt, as it's done here ? @ChihChengLiang

curryrasul commented 2 months ago

We should add changes to codehash.txt. The content is the cached mapping of code hash to the corresponding bytecode. When we run the EIP1153 test, cached entries should be automatically generated. We check in those entries to reduce the testing overhead.

@ChihChengLiang - We have an old version of ethereum/tests submodule, that doesn't contain Cancun tests. I updated it for the latest version and got the error when was running both default suite and EIP1153; and I also tried to switch to the commit that's scroll locked on and it also gives me error. The error is:

Error found not a str

ChihChengLiang commented 2 months ago

@curryrasul Can you push the update for the ethereum/test submodule? Can you give me a guide on how to reproduce the error so I can take a look?

curryrasul commented 2 months ago

@ChihChengLiang I updated the tests submodule

To reproduce the error:

  1. cd testool
  2. cargo run --release --bin testool -- --suite EIP1153 or cargo run --release --bin testool

It returns: [2024-05-15T17:44:24Z INFO testool] Using suite 'EIP1153' [2024-05-15T17:44:24Z INFO testool] Parsing and compiling tests... Error found not a str