search

privacy-scaling-explorations / zkevm-specs

332 stars 272 forks source link

Block Rewards #290

Open ed255 opened 1 year ago

ed255 commented 1 year ago

Currently we're only handling the spent gas related rewards to the coinbase address (this is done in EndTx). We should also handle the fixed reward in EndBlock (as described here, which is the EIP that should apply in our case https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1234.md)

It's not clear to me how we should treat the rewards associated to uncle and nephew blocks.

pinkiebell commented 1 year ago

Given that the PoW era is gone and PoA consensus doesn't have block rewards, should we even consider supporting that?

ed255 commented 1 year ago

Given that the PoW era is gone and PoA consensus doesn't have block rewards, should we even consider supporting that?

For the L2 zkRollup probably we don't need to consider these block rewards.

But we probably want to generate proofs of validity for L1 blocks before the PoA was implemented, so I think we have to consider this at some point. Ideally we'd want to verify L1 blocks from the genesis to now. Nevertheless I think having a zkEVM which can only verify blocks of the current fork/implementation is very useful; so we can definitely leave this issue as low priority and revisit it in the long term.

a2468834 commented 10 months ago

It's been a while after the merge had accomplished.

The recent discussion about pruning historical data of the execution layer might affect the idea @ed255 told. If EIP-4444 have been included in the hard fork, the processes of verifying L1 block rewards would be limited in a range of blocks in the beginning, and totally removed while the time window sliding.

Therefore I believe we might leave this issue as low priority or even don't need to implement it. 😊