search

privacy-tech-lab / gpc-privacy-choice

Privacy browser extension for researching GPC privacy choice user interfaces
https://www.privacytechlab.org
MIT License
15 stars 2 forks source link

Fix domain list entry on backend #218

Closed SebastianZimmeck closed 2 years ago

SebastianZimmeck commented 2 years ago

As we discussed earlier today, the domain list is not being populated per below.

Screen Shot 2022-05-31 at 9 47 42 AM

There are two potential solutions to this issue:

  1. Fix it such that it is being populated
  2. Just remove the functionality (UI and logic)

The first is preferred. However, more important than which of the two solutions we pick is to do it quickly. We can get the domains after the fact without the domain list just from the browsing history. So, by the end of the week we want to have everything ready.

@bella-tassone will work on this and @ekuller and @chunyuema will assist and review as necessary.

bella-tassone commented 2 years ago

I've been working on this issue for the past couple days, and while it is mostly functional, it has one small quirk. The domain list doesn't update immediately as a user visits a site, but only after. So if a user visits site A, then site B, site A will only show up in the domain list when the user opens site B. I don't think this is much of a problem, but I thought I'd document it anyways.

SebastianZimmeck commented 2 years ago

OK, thanks, @bella-tassone! I think that is a small quirk that we do not need to worry about. So, feel free to close this issue once the code is merged into main.