search

privacy-tech-lab / privacy-pioneer-web-crawler

Web crawler for detecting websites' data collection and sharing practices at scale using Privacy Pioneer
https://privacytechlab.org/
MIT License
0 stars 0 forks source link

Refactor Crawler Branches #26

Closed JoeChampeau closed 1 month ago

JoeChampeau commented 3 months ago

We're currently maintaining several different branches, some of which only differ in the XPIs they implement, and some of which have slight differences in functionality. We should take some time to eliminate outdated branches and work out a more logical organizational strategy.

SebastianZimmeck commented 3 months ago

Good point! Ultimately, we should only have one authoritative branch, main.

SebastianZimmeck commented 3 months ago

@dadak-dom, as you will be doing the crawl, please also get involved and huddle with @JoeChampeau on how to fix this issue.

dadak-dom commented 3 months ago

@SebastianZimmeck @JoeChampeau My understanding was that #25 will resolve this issue. Once I'm confident that my code works, we can merge everything test-related into issue-9. Will update once that's all set.

JoeChampeau commented 3 months ago

@dadak-dom #25 is part of the issue, but we also have branches that differ on the actual JS they implement, so we also need to ensure we identify the most updated branches (I had thought it was one of the issue-18 branches, but it could also be issue-9) and merge/purge the rest.

SebastianZimmeck commented 1 month ago

Per @dadak-dom the issue-9 branch is the most recent one that should have all the features. Merging that branch should resolve this issue. @dadak-dom will open a PR and @JoeChampeau will review it.

dadak-dom commented 1 month ago

Relevant PR has been merged 👍