search

privacy-tech-lab / privacy-pioneer

Privacy browser extension for analyzing web traffic of visited websites
https://www.privacytechlab.org/
Other
22 stars 1 forks source link

Fix notifications for IP and phone numbers (or update readme) #547

Closed SebastianZimmeck closed 5 months ago

SebastianZimmeck commented 7 months ago

The readme currently says:

Phone numbers do not currently generate notifications. This will be addressed soon. IP addresses sometimes do not generate notifications. This will be addressed soon.

SebastianZimmeck commented 7 months ago

We already discussed this point earlier (issue #526). @danielgoldelman will check and update the readme accordingly.

SebastianZimmeck commented 6 months ago

While a slightly different issue, this issue relates to #549.

SebastianZimmeck commented 6 months ago

@JoeChampeau takes a look and determines if this issue can be resolved along the lines of #549. Even if not, @JoeChampeau will explore other solutions. @dadak-dom and @danielgoldelman will review any PR.

JoeChampeau commented 6 months ago

PR linked with fix for phone notifications. Once it's approved I'll update the readme. IP notifications, as @jjeancharles noted in #526, are working just fine.

SebastianZimmeck commented 6 months ago

Excellent, @JoeChampeau!

SebastianZimmeck commented 5 months ago

@JoeChampeau, can you also update the readme as necessary?

For example, it still says "This will be addressed soon."

Also, is there anything else in the readme that needs to be adapated?

JoeChampeau commented 5 months ago

Thanks for the reminder @SebastianZimmeck, it should be updated now. I also altered one line in the Notifications section with updated information on some of the changes.

SebastianZimmeck commented 5 months ago

Thanks, @JoeChampeau!