search

privacy-tech-lab / privacy-pioneer

Privacy browser extension for analyzing web traffic of visited websites
https://www.privacytechlab.org/
Other
28 stars 1 forks source link

Fix broken watchlist mute functionality #590

Closed SebastianZimmeck closed 1 month ago

SebastianZimmeck commented 3 months ago

It looks like the watchlist mute functionality is broken. When I mute my email address, as below, I still keep getting alerts. @PattonYin, maybe you can start first checking whether you can replicate that behavior.

Screenshot 2024-09-02 at 1 23 25 PM

This is a minor issue. I am mostly opening it to not forget it. We have more important issues at the moment.

SebastianZimmeck commented 3 months ago

If this proves difficult to pinpoint, just removing the mute functionality completely will work as well. Besides the inconvenience of entering any watchlist keyword again, I do not see a disadvantage (although, we have to make sure; maybe, I am overlooking something).

SebastianZimmeck commented 2 months ago
Screenshot 2024-09-25 at 4 29 02 PM
SebastianZimmeck commented 2 months ago
Screenshot 2024-09-26 at 9 22 36 AM Screenshot 2024-09-26 at 9 20 41 AM
ananafrida commented 2 months ago

I was able to reproduce the bug. But it seems like the issue is with any keyword, not specific to email addresses.

SebastianZimmeck commented 2 months ago

I was able to reproduce the bug.

OK, great! The next steps are then to find out what causes this behavior and how the code can be changed to make it behave correctly.

SebastianZimmeck commented 2 months ago

One other point to consider, @ananafrida. As you mentioned, you could not reproduce the behavior when you installed PP from source and used Firefox Nightly.

What happens if you install PP from source on normal Firefox?

I am asking because maybe someone already fixed this issue and it is just not yet in the version deployed on the Firefox Add-on store.

ananafrida commented 1 month ago

The bug doesn't occur when I install PP in Firefox Nightly. In fact, Firefox Nightly doesn't give notifications at all. It only occurs when I install PP in normal Firefox. Does that bring us anywhere?

SebastianZimmeck commented 1 month ago

It only occurs when I install PP in normal Firefox.

Did you install using the current source code or the version from the Add-on store?

If you have not tested with the current source code version, is the bug there?

ananafrida commented 1 month ago

That's a good point. I haven't tested based on the current source code. I will try that and post updates here.

ananafrida commented 1 month ago

I ran the extension locally through the current source code, and the issue persists. The mute functionality doesn't work.

SebastianZimmeck commented 1 month ago

OK, then, please try to fix it.