privacybydesign / irmamobile

IRMA app for iOS and Android
Other
81 stars 20 forks source link

Inconsistent Recent Activity on the Home screen #126

Open thomasvandeweijer opened 1 year ago

thomasvandeweijer commented 1 year ago

What I expect to happen

For the Home screen to have a consistent number of Recent Activity entries (for example, the last 4)

What happened instead

On the Home screen under Recent Activity it first shows 4 activities when opening the app, but when switching back to Home screen after already being in the app it shows 2 activities instead.

How to reproduce

Hard and software

ivard commented 1 year ago

The expected behaviour is that it should always show the 2 most recent activities. So apparently something goes wrong in the case where this list gets updated when a new activity occurs.

ivard commented 1 year ago

The pattern that we use in the HistoryRepository currently makes it hard to resolve this issue. In retrospect the repository pattern is not really suitable there. Therefore, the class should be refactored to a bloc and in the new implementation this bug should be taken into account.