search

privacybydesign / irmamobile

IRMA app for iOS and Android
Other
78 stars 19 forks source link

F-Droid can't build #163

Closed licaon-kter closed 10 months ago

licaon-kter commented 1 year ago

ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/4053212260#L788

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/324469753aeca008a413f062a32cb259bd34106e

licaon-kter commented 1 year ago

ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/4068758851#L799

ivard commented 1 year ago

Thanks for the info. My first impression would be that it is related to a Dart/Flutter pub cache issue or a Java/Gradle version mismatch.

licaon-kter commented 1 year ago

You still use Flutter 2 when latest is 3.7.10?

ivard commented 1 year ago

Yes, that's correct. We didn't want to combine a major app update with a major Flutter upgrade. That's something we've planned for the following months.

licaon-kter commented 1 year ago

The actual issue was a bit above in the CI log: https://gitlab.com/fdroid/fdroiddata/-/jobs/4053212260#L590

Since that lib is not FOSS: https://github.com/juliansteenbakker/mobile_scanner/blob/master/android/build.gradle#L54

Ref: https://mvnrepository.com/artifact/com.google.mlkit/barcode-scanning/17.1.0

bobhageman commented 1 year ago

Thanks @licaon-kter for your help and insights! That explains it. We will search for an alternative which is fully open source and doesn't depend on proprietary Google libraries.

TheLastProject commented 1 year ago

I can't talk for Flutter as I have no experience with it, but I just wanted to say I've used https://github.com/zxing/zxing/ in my Java Android app Catima for years without ever running into issues on F-Droid (and I found it pretty easy to develop with). So maybe that info can help you find a suitable alternative.

ivard commented 1 year ago

It should be fixed in #181 . This will be included in the upcoming release v7.4.0. We'll also upgrade to Flutter 3, so that might require some updates in the FDroid pipeline.

licaon-kter commented 1 year ago

Any chance to set Flutter as a submodule? That way you can change the version at will and F-Droid will always use the right version. ;)

ivard commented 1 year ago

Currently, we mention our Flutter version in a CI script https://github.com/privacybydesign/irmamobile/blob/master/ci_scripts/install_flutter.sh

licaon-kter commented 1 year ago

Ah, that's fine, we can extract it from there then :+1:

Ping us when ready so we can update the recipe

ivard commented 1 year ago

I just published the new version.

licaon-kter commented 1 year ago

Done https://gitlab.com/fdroid/fdroiddata/-/commit/f28ac58db89557ad0adfabce8cbaa613a07d9b1a and we're picking flutter version from that script so if you keep it updated F-Droid will build with the correct one

ivard commented 1 year ago

Nice, thanks for your effort!

licaon-kter commented 10 months ago

Maybe something needs an update? https://gitlab.com/fdroid/fdroiddata/-/jobs/5283460015#L893

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/ca8806b83f1db7c14403e0abdc3c972be482df12

bobhageman commented 10 months ago

@licaon-kter Thanks for reporting. I've created an MR which fixes the issue, see: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13867