privacybydesign / irmamobile

IRMA app for iOS and Android
Other
79 stars 20 forks source link

PIN screen does not always show digit buttons 9 and 0 #248

Open ivard opened 11 months ago

ivard commented 11 months ago

The test fails half of the time with the following error:

java.lang.Exception: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════
The following assertion was thrown running a test:
The finder "zero widgets with text "Prefer a shorter PIN?"
(considering only hit-testable ones) (ignoring offstage widgets)"
(used in a call to "tap()") could not find any matching widgets.
When the exception was thrown, this was the stack:
#0 WidgetController._getElementPoint (package:flutter_test/src/controller.dart:1294:7)
#1 WidgetController.getCenter (package:flutter_test/src/controller.dart:1233:12)
#2 WidgetController.tap (package:flutter_test/src/controller.dart:554:18)
#3 WidgetTesterUtil.tapAndSettle (file:///home/runner/work/irmamobile/irmamobile/integration_test/util.dart:15:11)
#4 main.<anonymous closure>.<anonymous closure> (file:///home/runner/work/irmamobile/irmamobile/integration_test/settings_test.dart:231:20)
<asynchronous suspension>
#5 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:165:15)
<asynchronous suspension>
#6 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:982:5)
<asynchronous suspension>
The test description was:
change-pin

On some phones the buttons to enter the digits 9 and 0 sometimes fall off the screen. Not all failed test cases point in the direction of this, so it could be that there are more issues.

ivard commented 9 months ago

Pixel 6a in Google Firebase Test Lab:

image