Closed wanderview closed 1 year ago
@jyasskin PTAL. This is parented to the other PR. I'm not sure github handles that well so you may see changes from that other PR in this one as well. If you could give me a directional review of the new text that would be great. I'll be OOO till Tuesday and will try to address feedback then.
I've tried to address action items. PTAL. Thanks!
If the user sets their clock to earlier, I think all the activations and candidate bounces live longer than they're supposed to. So ... maybe we should have the bounce tracking timer check for |bounceTime| or |activationTime| being after |now|, and ... reset those to |now|? It's fine to leave that as a TODO in this PR.
Hmm, I'm unsure if it's worth doing anything about this. I'll add a TODO item to consider it, but it seems unlikely users will be doing this at scale. And in terms of a single user its not catastrophic for deletion to be delayed based on a rare event.
This text roughs in the general shape of how deletion will occur based on a timer comparing against timestamps stored in a global map. Some details still need to be resolved.
Preview | Diff