privacycg / nav-tracking-mitigations

Navigation-based Tracking Mitigations
https://privacycg.github.io/nav-tracking-mitigations/
35 stars 16 forks source link

Drafting Start/End navigation monkey patches #45

Closed amaliev closed 1 year ago

amaliev commented 1 year ago

Building off of wanderview@'s WIP PR that defines navigation start, and doing the same for navigation end.

I think that these are all the steps needed to account for server redirects. Our code adds logic around redirect chaining, committed/uncommitted redirects, and stateful/stateless bounces. But AFAICT these are only for metrics or experimental features.

In a future PR I'll include client-side redirect detection. These should be able to reuse the same hooks for navigation start/end.


Preview | Diff

jyasskin commented 1 year ago

My understanding is that this is being superseded by #46, so I only reviewed that PR.

jyasskin commented 1 year ago

This was incorporated into #46.