privacycg / private-click-measurement

Private Click Measurement
https://privacycg.github.io/private-click-measurement/
200 stars 8 forks source link

Optional ad campaign id and ad attribution data #16

Open kdzwinel opened 5 years ago

kdzwinel commented 5 years ago

Ad attribution data and ad campaign id are both required parameters while they don't seem to be required to provide meaningful feedback e.g.:

In both cases 0 can be provided as the value of the unused parameter, but it would be more elegant to make those fields optional instead.

annevk commented 4 years ago

Wouldn't that give an additional bit? (Defaulting to 0 seems reasonable.)

johnwilander commented 4 years ago

With Anne's suggestion, this seems fine. We should make this change.