privacycg / storage-access

The Storage Access API
https://privacycg.github.io/storage-access/
212 stars 27 forks source link

Adapt changes to navigation to session history rewrite #137

Closed johannhof closed 1 year ago

johannhof commented 1 year ago

We have some new build errors:

LINE ~275: No 'dfn' refs found for 'current entry'.
[=current entry=]

in https://privacycg.github.io/storage-access/#navigation

I suspect that this comes from https://github.com/whatwg/html/pull/6315. I asked @domenic about an easy migration path for this text but it seems like the solution might entail a little more work, so here's two thoughts:

@annevk thoughts?

annevk commented 1 year ago

If we remove the warning check we'll likely end up introducing quite a few new problems. I would prefer we add an issue marker and remove the broken references (keeping the words, but no longer linking them) if we want a temporary solution.

johannhof commented 1 year ago

Ok that seems like a better solution to me as well, then. I'll comment on the PR.

johannhof commented 1 year ago

I think this was solved with #121 but please correct me if I'm wrong @cfredric

cfredric commented 1 year ago

I think you meant #141, but I agree, #136 fixed the build by unlinking "current entry", and as of #141 the spec no longer references the "current entry" directly, so this seems fixed.

johannhof commented 1 year ago

Oh, yes, I meant #141, sorry.