search

privacyguides / privacyguides.org

Protect your data against global mass surveillance programs.
https://www.privacyguides.org
Creative Commons Attribution Share Alike 4.0 International
2.54k stars 198 forks source link

Fix the grammar for Criteria in Cloud Storage. #2543

Closed lamtrinhdev closed 2 months ago

lamtrinhdev commented 2 months ago

Fix the grammar for Criteria in Cloud Storage.

Changes proposed in this PR:

- [x] I agree to the terms listed below:
Contribution terms (click to expand)

1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.

github-actions[bot] commented 2 months ago

Your preview is ready!

Name Link
Latest commit bff6b18dd2d7186231a999f42d714a09320e94d1
Preview https://2543--glowing-salamander-8d7127.netlify.app/
jonaharagon commented 2 months ago

Thank you for the PR!

Yes, including the "that" is more technically correct for formal writing. Even though we would normally want it written this way, I'm not going to merge this PR because:

  1. Including "that" is still optional, it does not really change the meaning or connotation of this sentence.
  2. This sentence is on almost every page of the website, not just cloud storage, so this PR is incomplete.
  3. Most importantly, changing this sentence means that the sentence will have to be re-translated in every language again.

Given 1 is true, I don't want to force an automatic retranslation of this sentence for our translators just for a very minor change, even though it is technically better. Thanks for keeping an eye on this though :)