privacyguides / privacyguides.org

Protect your data against global mass surveillance programs.
https://www.privacyguides.org
Creative Commons Attribution Share Alike 4.0 International
2.54k stars 198 forks source link

Cannot load infomation in "Multi-Factor Authenticators" popup. #2551

Open lamtrinhdev opened 2 months ago

lamtrinhdev commented 2 months ago

Bug description

When I access "Knowlegde Base" => "Introduction to Passwords" section. It does not show infomation of "multi-factor authentication" popup. At least, it should show 2 first line titiles they are

"Hardware Security Keys YubiKey ...."

You can refer attached photo for more details.

IMG_6136

Affected pages

-

Browser

No response

Operating System

No response

Before submitting

redoomed1 commented 2 months ago

Thanks for observing this issue, @lamtrinhdev ! I think the behavior of the popup here bears some similarity to the one I noted in this comment: https://github.com/privacyguides/privacyguides.org/pull/2451#issuecomment-2037930893

I think that the previews for "whole page links" cover anything until the first permalink on the page, which explains the above behavior.

On the Multi-Factor Authenticators page, there is no text between the title of the page and the first permalink (i.e., the "Hardware Security Keys" heading), which explains the lack of information in the popup on the page you show in this issue.

lamtrinhdev commented 2 months ago

Thank you for your comment @redoomed1 . Just raise the ticket to Admin to consider to enhance if needed.

jonaharagon commented 2 months ago

Yeah, we can fix this, because I think we should have an introductory paragraph explaining what MFA is, like we do on other pages.

We should also probably start to rewrite some of those introductions with this new hover feature in mind.

lamtrinhdev commented 2 months ago

It sounds great, @jonaharagon .

redoomed1 commented 4 weeks ago

Behavior was fixed with #2594

fixed-instant-preview