search

privacyidea / pi-authenticator

OTP Authenticator App for privacyIDEA Authentication Server
Other
35 stars 19 forks source link

Suggestion: new token overview #344

Closed AutoComplete1 closed 1 month ago

AutoComplete1 commented 10 months ago

Hello everyone,

I have recently heard from many of my colleagues (we use pi-authenticator for work) that it is not possible to delete or edit tokens in the app. My first idea was also to extend the instructions as described in the Google reviews, but I know too well that users don't look at instructions and try it themselves. The swipe gesture is not visible to the user, which is why I replaced it with three dots.

Label The label of the token was previously displayed as subtext under the token code. I saw as problem here that a user will initially search for a label to get the correct token code, so why not put it first?

Container per token Just looks better in my opinion. This makes each token a visible, coherent object for the user.

Code I have continued to call the new "actions" actions. From my point of view, it is still an action and not a menu or anything like that. If you want to change the names of the classes, that's no problem (i.e. DefaultDeleteAction). If a merge is possible and I have to adjust something, please let me know. I started the whole thing for fun and for learning purposes, but I think the result is quite nice now.

The app has been tested on Android and in the iOS simulator.

Screenshots

Android (one token without label to demonstrate that this still works)

drawing

iOS

drawing

Edit: I forgot to mention one more thing. The app cannot currently be used by blind people. To incorporate this in the future, a structure with buttons makes more sense. I don't know how a blind person can perform a swipe action. As far as I know, only a tap action can be performed (https://api.flutter.dev/flutter/widgets/Semantics-class.html)

AutoComplete1 commented 10 months ago

Now fully tested on iPhone 13 and Samsung Galaxy A52

nilsbehlen commented 9 months ago

Hi, first of all, thanks for your PR. @frankmer will be back next week and we will discuss what we can make of this. We probably won't merge it as is because that is a lot of change, but you have brought up some valid points that we should and will consider. Maybe we can even look into having different layouts.

AutoComplete1 commented 9 months ago

Hi,

first of all, thanks for your PR. @frankmer will be back next week and we will discuss what we can make of this. We probably won't merge it as is because that is a lot of change, but you have brought up some valid points that we should and will consider. Maybe we can even look into having different layouts.

All right, if there are any changes I need to make for a merge to be possible, I'll be happy to make them. For example, how the swipe is replaced for folders is still open. The folder icon is currently at the position of the new icon.

Regarding the support for blind people (flutter only), I have not found anything that a swipe is possible. Here you always need elements (i.e. buttons) that contain a label with a description. Blind people can then have these read out to them.