privacyidea / privacyidea-authenticator

Android OTP Authenticator App for privacyIDEA Authentication Server
Other
13 stars 10 forks source link

mismatch in documentation/implementation for parameter "2step_output" #104

Closed hurzhurz closed 4 years ago

hurzhurz commented 4 years ago

I don't know which one is correct, but I noticed a mismatch between documentation and implementation for the "2step_output" parameter:

Documentation says it is given in bits: https://github.com/privacyidea/privacyidea-authenticator/blob/master/doc/README.md#2step_output

But here it gets multiplied by 8, so probably expected to be bytes: https://github.com/privacyidea/privacyidea-authenticator/blob/master/app/src/main/java/it/netknights/piauthenticator/viewcontroller/MainActivity.java#L402

nilsbehlen commented 4 years ago

Hi, thanks for pointing this out. It seems the documentation was not updated (until now), since implementation works.

hurzhurz commented 4 years ago

Great that you already updated it! Though I would suggest to also change the example: 2step_output=160 to 2step_output=20

nilsbehlen commented 4 years ago

you're right, fixed it.