search

privacylab / talek

a Private Publish Subscribe System
BSD 2-Clause "Simplified" License
47 stars 5 forks source link

Process Reads periodically for degenerate cases #38

Closed willscott closed 7 years ago

willscott commented 7 years ago

when testing, we'll often have a single client and a single read at a given them. Centralize will now fill up the batch of reads with additional empty requests every ReadInterval so that the read will always complete in a timely manner in these cases.

ryscheng commented 7 years ago

Just 1 comment, not sure I understand why we're padding batchreadrequest to the same size.

willscott commented 7 years ago

Okay to leave readbatch padding at centralized for now, and push the logic into the shard when we refactor frontend/centralized/shard responsibilities?

ryscheng commented 7 years ago

👍