search

privacylab / talek

a Private Publish Subscribe System
BSD 2-Clause "Simplified" License
48 stars 5 forks source link

shorter handle representation. #68

Closed willscott closed 7 years ago

willscott commented 7 years ago

one of two parts of #66

ryscheng commented 7 years ago

Is this ready for review or are we waiting for a part 2 of 2?

willscott commented 7 years ago

the trust domains in client.conf should probably also get hex treatment rather than the go json encoder default treatment of array of bytes.

That's on my list to do with #7 - having the connection between the client and frontend be over TLS with a pinned server cert.

willscott commented 7 years ago

which is to say. this one is ready for review.

willscott commented 7 years ago

addressed comments

willscott commented 7 years ago

added an Equal method. go convention is that this is of the form libtalek.Equal(a, b *Handle), not handle.Equal(other). aliasing rules also mean we only get one of those per package, so i went with handle rather than topic.

ryscheng commented 7 years ago

:+1: