search

privacylab / talek

a Private Publish Subscribe System
BSD 2-Clause "Simplified" License
47 stars 5 forks source link

support multi-message messages #79

Closed willscott closed 7 years ago

willscott commented 7 years ago

This fixes #41 It also updates client_test.go to work with new process for generating request vectors introduced in #78

willscott commented 7 years ago

I made a formalized type for messages that encapsulates the split/join logic.

I'm going to argue that we're already over-engineering this component compared to the protocol at this point, and I don't think we can do a particularly good job codifying more about what the fragments look like or need to support in terms of reassembly until we've actually developed what that protocol looks like.

ryscheng commented 7 years ago

Looks good thanks for the changes. I agree we can defer the out of order stuff till later 👍