privacysandbox / aggregation-service

This repository contains instructions and scripts to set up and test the Privacy Sandbox Aggregation Service
Apache License 2.0
62 stars 30 forks source link

docs(debugging): update post body json to remove capital `Job` #37

Closed michaelpeterswa closed 6 months ago

michaelpeterswa commented 9 months ago

I noticed it says in CONTRIBUTING.md that this project isn't accepting contributions, but hopefully a small documentation change is allowed. The capital J in job creates the following error in the frontend service (/v1alpha1/createJob endpoint) which is a bit unclear if you don't notice the extra capital:

{
    "code": 6,
    "message": "Duplicate job_request_id provided: job_request_id= is not unique.",
    "details": [
        {
            "reason": "DUPLICATE_JOB_KEY",
            "domain": "",
            "metadata": {
            }
        }
    ]
}

This PR addresses that small inconsistency to match the example provided here GCP Aggregation Service - Testing The System

google-cla[bot] commented 9 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

rulohani commented 9 months ago

Thanks for the doc update, Michael. We will update it in the repo.

hostirosti commented 6 months ago

This has been addressed, thank you for your contribution @michaelpeterswa.