privacytests / privacytests.org

Source code for privacytests.org. Includes browser testing code and site rendering.
https://privacytests.org
MIT License
797 stars 23 forks source link

prefetch cache - Firefox nightly / stable discrepancy - possible bug in detecting whether prefetch-cache is partitioned? #196

Closed mb closed 4 months ago

mb commented 5 months ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1840840#c7

Manuel and I had a look at the test. A few things we noticed:

  • On regular browsing mode, the test shows multiple "No requests received". I take it that the response failed maybe? The question is why.
  • On private browsing mode, the adding the prefetch link to the header doesn't seem to actually trigger a prefetch, so that may be the cause the test appears to be failing on PB mode. The assumption is that in a different session it would return a different count string, but since the prefetch doesn't work, it actually always only does one fetch, so we get the same string. The prefetch not working may still be a bug in Firefox, we need to investigate that, but I think the test is also slightly wrong, as it doesn't actually check what it says it does.

Arthur, do you think the test might be wrong here?

The test has been succeeding in Nightly at least since 2023-11-03 (Nightly 121). Stable is currently Firefox 122. So anything that got fixed in 121 should be in stable by now. I'm wondering if you could take a look at why that tests still says that it failed in Firefox stable and tell us what you think.

mb commented 4 months ago

Tests are now also passing on Firefox stable. Inconsistency is gone.