Assorted minor issues from Thorin

privacytests / privacytests.org

Source code for privacytests.org. Includes browser testing code and site rendering.

https://privacytests.org

MIT License

798 stars 23 forks source link

Assorted minor issues from Thorin #77

Open arthuredelstein opened 2 years ago

arthuredelstein commented 2 years ago

Rather than create a new issue

Tor Browser has a Desktop + Desktop private mode. Isn't the first redundant?
same with TB Nightly and Nightly private mode
https://privacytests.org/news.html - link for 10 desktop is for current desktop issue
TB Tor test
    issue 10: desktop private mode mode shows Tor as failed
    issue 10.1: desktop shows Tor as failed

Change in issue 11 - font isolation is now a fail for gecko desktop. Font cache should be isolated by network partitioning

arthuredelstein commented 2 years ago

https://privacytests.org/news.html - link for 10 desktop is for current desktop issue

Fixed by 8f76e4dad7022cae7b028960bce6eb312ec83b9b

arthuredelstein commented 2 years ago

TB Tor test issue 10: desktop private mode mode shows Tor as failed issue 10.1: desktop shows Tor as failed

Ugh, looks like it failed 1/5 times in both cases. Apparently I need to find a more robust way of detecting Tor nodes, although I am surprised that onionoo wouldn't give the right answer.

arthuredelstein commented 2 years ago

Tor Browser has a Desktop + Desktop private mode. Isn't the first redundant? same with TB Nightly and Nightly private mode

They're the same mode -- it's just that I want to display Tor Browser in both pages for comparison. I will try to clean that up at some point.

Thorin-Oakenpants commented 2 years ago

I can detect TB via JS 100% reliably over all platforms ( ~15ms using resource://), but that's the browser, not the protocol .. so not much help for you there, sorry

it's just that I want to display Tor Browser in both pages

sounds legit :)

Thorin-Oakenpants commented 2 years ago

https://privacytests.org/news.html

issue links are whack

13 links to default (should point to 13)
12 links to 13
11 link to 10.1

arthuredelstein commented 2 years ago

https://privacytests.org/news.html

issue links are whack
* 13 links to default (should point to 13)

It points to default because it's the current issue. :)

* 12 links to 13

* 11 link to 10.1

Thanks for reporting these! Now fixed.

Thorin-Oakenpants commented 2 years ago

It points to default because it's the current issue. :)

I know, but linking to 13 also works, so why not just do it once :)

Thorin-Oakenpants commented 2 years ago

https://github.com/arthuredelstein/privacytests.org/issues/75#issuecomment-1003461874

Change in issue 11 - font isolation is now a fail for gecko desktop. Font cache should be isolated by network partitioning

I think when we split from #75 the font issue got buried: here's an update with No 18 LW-font

the third font being tested seems problematic. LW uses RFP which limits fonts to kBaseFonts (on Linux that's gated)