private-attribution / ipa

A raw implementation of Interoperable Private Attribution
MIT License
40 stars 23 forks source link

Add more tracing to the infrastructure #1101

Closed akoshelev closed 3 months ago

akoshelev commented 3 months ago

I've been using these for quite a while, but forgot to commit them to the main branch. This logs the following operations:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.96%. Comparing base (2af7b98) to head (802407a).

Files Patch % Lines
ipa-core/src/helpers/buffers/ordering_sender.rs 42.85% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1101 +/- ## ======================================= Coverage 90.95% 90.96% ======================================= Files 184 184 Lines 26079 26076 -3 ======================================= - Hits 23720 23719 -1 + Misses 2359 2357 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akoshelev commented 3 months ago

The messages are terse, but that's probably okay as long as they are emitted with the module name.

yea that is the reason - strings are getting long in logs.

akoshelev commented 3 months ago

Merging it as the CI run on my local fork passed: https://github.com/akoshelev/raw-ipa/actions/runs/9281219804/job/25536830009