Closed bmcase closed 2 months ago
Attention: Patch coverage is 99.50617%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 91.24%. Comparing base (
10ae23a
) to head (1290488
).
Files | Patch % | Lines |
---|---|---|
ipa-core/src/protocol/dp/mod.rs | 99.50% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As promised to @martinthomson earlier, here is a separate PR to move around the DP related code.
I wanted to keep this as a separate PR for just moving code otherwise the diffs will be harder to review if there are also more substantive changes happening.
Essentially what is happening here are two moves:
protocol/dp
is being moved intoprotocol/ipa_prf/oprf_padding
. The main code we will be using from here is related to oprf dummies so makes sense to be in theipa_prf
module. There is some other code for noise generation in the clear that we probably won't be using once the new DP in MPC code is being used, but I'll come back and clean this up later.protocol/ipa_prf/dp
is being moved intoprotocol/dp
. As Martin noted this is really a general functionality and not necessary to have it in theipa_prf
module.All other changes are fixing imports.