private-attribution / ipa

A raw implementation of Interoperable Private Attribution
MIT License
40 stars 23 forks source link

Moving DP related code #1117

Closed bmcase closed 2 months ago

bmcase commented 3 months ago

As promised to @martinthomson earlier, here is a separate PR to move around the DP related code.

I wanted to keep this as a separate PR for just moving code otherwise the diffs will be harder to review if there are also more substantive changes happening.

Essentially what is happening here are two moves:

  1. the code previously in protocol/dp is being moved into protocol/ipa_prf/oprf_padding. The main code we will be using from here is related to oprf dummies so makes sense to be in the ipa_prf module. There is some other code for noise generation in the clear that we probably won't be using once the new DP in MPC code is being used, but I'll come back and clean this up later.
  2. the code previously in protocol/ipa_prf/dp is being moved into protocol/dp. As Martin noted this is really a general functionality and not necessary to have it in the ipa_prf module.

All other changes are fixing imports.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 99.50617% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.24%. Comparing base (10ae23a) to head (1290488).

Files Patch % Lines
ipa-core/src/protocol/dp/mod.rs 99.50% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1117 +/- ## ========================================== - Coverage 91.24% 91.24% -0.01% ========================================== Files 187 187 Lines 26718 26718 ========================================== - Hits 24380 24378 -2 - Misses 2338 2340 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.