search

private-attribution / ipa

A raw implementation of Interoperable Private Attribution
MIT License
40 stars 23 forks source link

Use fewer .0 and .1 #1119

Closed benjaminsavage closed 2 months ago

benjaminsavage commented 3 months ago

In his review of #1109, @andyleiserson suggested either using a struct with a "left" and "right" or immediately destructuring. I've opted for the latter approach since the two items in the tuple returned by gen_proof_shares_from_prss mean different things in practice, and just destructuring and giving them descriptive names (like we do within gen_artefacts_from_recursive_step) is probably the way to go.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.24%. Comparing base (7bb1325) to head (124218b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1119 +/- ## ========================================== + Coverage 91.23% 91.24% +0.01% ========================================== Files 187 187 Lines 26776 26784 +8 ========================================== + Hits 24428 24440 +12 + Misses 2348 2344 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.