search

private-attribution / ipa

A raw implementation of Interoperable Private Attribution
MIT License
40 stars 23 forks source link

Revise BasicProtocols #1128

Closed andyleiserson closed 2 months ago

andyleiserson commented 2 months ago

The old BasicProtocols was no longer used anywhere. This replaces it with a version that includes only the basic protocols that have been vectorized. It also makes some progress towards not exposing semi-honest protocols on arbitrary contexts (which is unsafe).

Split from #1112.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.49%. Comparing base (3682ce1) to head (29b75e2).

Files Patch % Lines
ipa-core/src/ff/ec_prime_field.rs 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1128 +/- ## ========================================== + Coverage 91.46% 91.49% +0.03% ========================================== Files 189 189 Lines 27217 27221 +4 ========================================== + Hits 24894 24907 +13 + Misses 2323 2314 -9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andyleiserson commented 2 months ago

I will merge this via #1129 since that one passed the coverage check. The missing coverage is on:

    fn to_extended(&self) -> Self::ExtendedField {
        *self
    }

Not very interesting, and in any case, it should be covered later when we use MAC-based malicious security for Fp25519, for PRF evaluation.