Closed andyleiserson closed 3 months ago
Attention: Patch coverage is 97.34043%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 91.65%. Comparing base (
614c019
) to head (566d9f1
). Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
ipa-core/src/error.rs | 0.00% | 3 Missing :warning: |
ipa-core/src/helpers/mod.rs | 96.00% | 1 Missing :warning: |
ipa-core/src/protocol/ipa_prf/shuffle/base.rs | 94.73% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
thanks for addressing this issue quickly Andy!
This does two things:
~Doing something like
set_total_records(vec.len())
with an empty vec is still a panic at runtime. We could haveset_total_records
takeNonZeroUsize
, but that would require changing a bunch of things that call it to explicitly handle the zero case.~ (Edit: resolved in updated version)Fixes #897