Closed akoshelev closed 3 months ago
Attention: Patch coverage is 92.67016%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 91.87%. Comparing base (
02f5467
) to head (9714c77
). Report is 52 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This change adds a new simple test circuit and integration tests for it. This circuit does not do anything sophisticated and the need for it is dictated by #1141 where I need to test that inputs of size > 2Gb can be handled by our MPC helpers.
I tried to use
test-multiply
but it just takes too long to process inputs of this size. I estimated ~300M field value pairs need to be submitted to exceed $2^{31}-1$ input size and that makes that circuit to run for 8+ mins.This circuit is much faster for two reasons. First, it does not require communication. Second, it generates input and shares it using iterators. That makes a big difference - my experiments showed that it takes roughly 9 mins to get
test-multiply
inputs delivered and ~50 seconds fortest-add
. It can be further optimized because we collect everything. in.share
, but this implementation is good enough for me.My goal is to use this circuit in a integration test that we run only in CI and that checks inputs greater than $2^31-1$ can be sent via our
report_collector
client