search

private-attribution / ipa

A raw implementation of Interoperable Private Attribution
MIT License
41 stars 23 forks source link

Malicious Fp25519 share conversion #1208

Closed andyleiserson closed 1 month ago

andyleiserson commented 1 month ago

Modify Fp25519 share conversion to support DZKP-based malicious security. By implementing the logic to periodically verify batches in the validator, significantly fewer changes to the protocol are required.

Additional changes are required to make batched proof verification work with seq_join -- right now, there is nothing to restrict seq_join (including validated_seq_join) from scheduling futures that should not be writing into the current batch.

andyleiserson commented 1 month ago

I think there should be a test that induces a DZKP validation failure and verifies (1) error from primary record, (2) error from non-primary records, (3) success of unaffected batch. But I didn't want to delay opening this PR to have that, and I may work on rebasing the batching changes first.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.78%. Comparing base (4fe0b41) to head (d03c32f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1208 +/- ## ========================================== + Coverage 92.20% 92.78% +0.58% ========================================== Files 197 197 Lines 30298 30523 +225 ========================================== + Hits 27935 28320 +385 + Misses 2363 2203 -160 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.