search

private-attribution / ipa

A raw implementation of Interoperable Private Attribution
MIT License
41 stars 23 forks source link

pre-commit tests passing when CI fails #1224

Open bmcase opened 1 month ago

bmcase commented 1 month ago

I've had it happen a couple times where a test will pass in the pre-commit stage but then the same test will fail when running in the CI.

I can recreate the test failing locally like in the CI if I run it with release and a feature flag. Here is an example:

cargo test --release --lib protocol::ipa_prf::tests::semi_honest_degenerate --features "shuttle multi-threading"

My question is if we should update the pre-commit tests to more exactly capture these scenarios that are run in the CI check.yml?

In particular the CI (check.yml) seems to run the concurrency tests (which is where I've seen all these occur) but it seems the pre-commit does not. 

      - name: Run concurrency tests
        run: cargo test --release --features "shuttle multi-threading"