private-attribution / ipa

A raw implementation of Interoperable Private Attribution
MIT License
41 stars 23 forks source link

SaturatedAdditionStep is still using SixteenBitStep #1235

Open andyleiserson opened 3 weeks ago

andyleiserson commented 3 weeks ago

This doesn't seem right. Maybe if we're assuming we can't saturate the 32-bit output? But if that's the case, we should eliminate the saturated addition entirely.

The fix is simple, but we ought to have some sort of test or check that the steps are sized appropriately.