search

private-attribution / ipa

A raw implementation of Interoperable Private Attribution
MIT License
41 stars 23 forks source link

Malicious security for top-level OPRF IPA protocol #1252

Closed andyleiserson closed 5 days ago

andyleiserson commented 1 week ago

Current status is that there are compact gate issues to debug with the DZKPs:

thread 'tokio-runtime-worker' panicked at /Users/Andy/Development/ipa/target/debug/build/ipa-core-5e42fe9f15b7d280/out/protocol_gate.rs:192137:17:
unexpected narrow for ProtocolGate(/ipa_prf/convert_fp25519) => ZeroKnowledgeProofValidateStep(d_z_k_p_malicious_protocol)
stack backtrace:
thread 'tokio-runtime-worker' panicked at /Users/Andy/Development/ipa/target/debug/build/ipa-core-5e42fe9f15b7d280/out/protocol_gate.rs:192137:17:
unexpected narrow for ProtocolGate(/ipa_prf/convert_fp25519) => ZeroKnowledgeProofValidateStep(d_z_k_p_malicious_protocol)
stack backtrace:
thread 'tokio-runtime-worker' panicked at /Users/Andy/Development/ipa/target/debug/build/ipa-core-5e42fe9f15b7d280/out/protocol_gate.rs:192137:17:
unexpected narrow for ProtocolGate(/ipa_prf/convert_fp25519) => ZeroKnowledgeProofValidateStep(d_z_k_p_malicious_protocol)

Test case is cargo test -p ipa-core --test compact_gate --no-default-features --features "cli web-app real-world-infra test-fixture compact-gate" -- compact_gate_cap_8_no_window_malicious

andyleiserson commented 5 days ago

Rather than add a bunch more stuff to this PR, I updated the tests to avoid running malicious IPA with compact gate. I'll open a new one with the compact gate fixes.

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 91.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 92.49%. Comparing base (f199c46) to head (6c52bb2). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
ipa-core/src/query/executor.rs 28.57% 5 Missing :warning:
ipa-core/src/test_fixture/ipa.rs 16.66% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1252 +/- ## ========================================== + Coverage 92.47% 92.49% +0.02% ========================================== Files 201 201 Lines 31925 31997 +72 ========================================== + Hits 29522 29597 +75 + Misses 2403 2400 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.