Closed akoshelev closed 1 month ago
Attention: Patch coverage is 56.33803%
with 31 lines
in your changes missing coverage. Please review.
Project coverage is 93.54%. Comparing base (
58e3a25
) to head (67e3828
). Report is 4 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
ipa-core/src/query/executor.rs | 32.50% | 27 Missing :warning: |
ipa-core/src/app.rs | 20.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can you check out why the tests are failing?
yea it does not seem relevant to this change. Nightly Rust seems to be broken again.
Running unittests src/lib.rs (target/debug/deps/ipa_step_derive-f6e14ae7c576baea)
/home/runner/work/ipa/ipa/target/debug/deps/ipa_step_derive-f6e14ae7c576baea: error while loading shared libraries: libstd-f157c25fb2dbfbe0.so: cannot open shared object file: No such file or directory
error: test failed, to rerun pass `-p ipa-step-derive --lib`
Caused by:
process didn't exit successfully: `/home/runner/work/ipa/ipa/target/debug/deps/ipa_step_derive-f6e14ae7c576baea` (exit status: 127)
It is failing on other PRs as well - https://github.com/private-attribution/ipa/actions/runs/11221190944/job/31190994974. I can't find the issue in Rust repo that matches this problem, probably it is a fairly fresh breakage
I want to take another look at the shape of this API to make sure it is ergonomic enough to use, so this should be a draft for now
I am confident now that this API works, will be submitting a follow up PR soon
The time has come to have a need to have a precise control over which runtime is used to run queries. The reason for that is that we had another occurrence of HTTP keep-alive timeout that aligns with OPRF computation.
https://draft-mpc.vercel.app/query/view/nervy-fret2024-10-05T0245
The root cause for this is PRF computation blocking scheduler for too long, so it does not schedule Hyper task to respond to
status
requests from RC, or to accept data from another peer. While it deserves to be fixed (I believe @danielmasny was looking into why we trash CPU so badly in PRF), it is not OK to crash if that happens.This change just does the plumbing to allow dedicated runtime to be provided for query executors.