private-attribution / ipa

A raw implementation of Interoperable Private Attribution
MIT License
42 stars 25 forks source link

Exclude all packages from sanitizers except ipa_core #1341

Closed akoshelev closed 1 month ago

akoshelev commented 1 month ago

We are getting errors in our CI like these, so everything is blocked now: https://github.com/private-attribution/ipa/actions/runs/11243388038/job/31259140713

Thanks to @andyleiserson who pointed that out that we could actually exclude packages that are failing because we only use unsafe features in ipa-core. He also figured that this failure may be related to this https://github.com/lu-zero/cargo-c/issues/398#issuecomment-2349191336 which means that the fix may be coming soon

I checked the fix in my repo and it appears to be working: https://github.com/akoshelev/raw-ipa/actions/runs/11246313348/job/31267934735

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.60%. Comparing base (b97a908) to head (357ecde). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1341 +/- ## ========================================== - Coverage 93.61% 93.60% -0.01% ========================================== Files 209 209 Lines 34274 34274 ========================================== - Hits 32084 32082 -2 - Misses 2190 2192 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.