search

private-attribution / ipa

A raw implementation of Interoperable Private Attribution
MIT License
42 stars 25 forks source link

Suppress metrics table in passing test runs #1400

Closed andyleiserson closed 3 weeks ago

andyleiserson commented 3 weeks ago

std::io::stdout() is not captured in test runs -- see https://github.com/rust-lang/rust/issues/90785.

The Display implementation for comfy_table::Table assembles everything into a string anyways (actually worse -- it assembles into a Vec<String> and then calls join). So, even if we were to have other places where we want the std::io::Write interface, there is unlikely to be a performance benefit of the previous implementation.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.54%. Comparing base (95dbe6a) to head (04ce112). Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
ipa-core/src/telemetry/stats.rs 95.23% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1400 +/- ## ========================================== - Coverage 93.68% 93.54% -0.15% ========================================== Files 223 223 Lines 37765 38261 +496 ========================================== + Hits 35382 35792 +410 - Misses 2383 2469 +86 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.