search

private-attribution / ipa

A raw implementation of Interoperable Private Attribution
MIT License
42 stars 25 forks source link

Complete query API for sharded environments #1447

Closed akoshelev closed 5 days ago

akoshelev commented 1 week ago

As we discussed, we want to make the complete query API simple to implement. That means, we have an assumption that all shards communicate their results to the leader. That leaves complete API to just clean up the state on each shard and return response from the leader. This PR does exactly that.

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.54%. Comparing base (f42e334) to head (e8e9e8e). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1447 +/- ## ======================================== Coverage 93.53% 93.54% ======================================== Files 230 230 Lines 40683 40821 +138 ======================================== + Hits 38053 38184 +131 - Misses 2630 2637 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

akoshelev commented 5 days ago

Draft is showing green light: https://draft-mpc.vercel.app/query/view/more-patio2024-11-21T1941