Some minor remarks - Githubissues

private-face / jquery.fullscreen

jQuery plugin for opening page elements in fullscreen mode.

MIT License

148 stars 83 forks source link

Some minor remarks #28

Closed maspiter closed 9 years ago

maspiter commented 9 years ago

The example index.html from jquery.fullscreen-master references version 0.4.1 while only 0.4.2 is included in the download, thus doesn't work OOTB.
version 0.4.1 still has version nr 0.4.0 in it's description
version 0.4.1 doesn't work in IE11
version 0.4.2 is not available under tags so cannot be used through rawgit CDN unless with master branch but this is not recommended

private-face commented 9 years ago

The example index.html from jquery.fullscreen-master references version 0.4.1 while only 0.4.2 is included in the download, thus doesn't work OOTB.

version 0.4.1 still has version nr 0.4.0 in it's description

Fixed with switching to better build process (with grunt).

version 0.4.1 doesn't work in IE11

Should be fixed in v 0.4.2 and above.

version 0.4.2 is not available under tags so cannot be used through rawgit CDN unless with master branch but this is not recommended

Fixed.